Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dom related reference files according to new IE spec #2645

Closed
wants to merge 2 commits into from

Conversation

zhengbli
Copy link
Contributor

@zhengbli zhengbli commented Apr 6, 2015

The IE team started to issue new specs in the format of XML files instead of webidl files for upcoming API changes. The new dom.generated.d.ts and webworker.d.ts are generated from the new XML specs to be consistent with IE Dom API changes.

@msftclas
Copy link

msftclas commented Apr 6, 2015

Hi @zhengbli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Zhengbo Li). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@danquirk
Copy link
Member

danquirk commented Apr 6, 2015

Have we run this change against our real world code suites? We need to make sure changing the order of overloads doesn't break anything.

@zhengbli
Copy link
Contributor Author

zhengbli commented Apr 6, 2015

There are indeed a bunch of breaking changes that cause 57 rwc tests to fail. And the reasons of failure are documented at: http://1drv.ms/1DFuYE7. Should the rwc tests be changed before merging?

Also, what do you mean by "the order of overloads"?

@mhegazy
Copy link
Contributor

mhegazy commented Apr 6, 2015

@zhengbli can you list the issues that will be fixed by this change as well.

@mhegazy
Copy link
Contributor

mhegazy commented Apr 6, 2015

looking at this diff is hard. can we sort the declarations in some order to make the diff more useful

@mhegazy
Copy link
Contributor

mhegazy commented Apr 6, 2015

also i do not think you need extensions.d.ts anymore. i could be wrong though. We have added them as some types in dom.generated.d.ts depended on them. if they are not used we should remove them and let es6.lib.d.ts be the only definition of these types.

@zhengbli
Copy link
Contributor Author

zhengbli commented Apr 7, 2015

Issues that would be fixed:
#2437 Missing properties: document.pointerLockElement and MouseEvent.movement
#2416 WheelEvent constructor in lib.d.ts
#2029 Type definition of CustomEvent constructor needs parameter(s).
#1852 DOMStringMap is defined as an empty interface - this makes it awkward to use
#1850 "SOURCE"
#1618 "getElementsByTagName('svg')" does not returns NodeList of SVGSVGElement, but generic NodeList.
#1302 add declarations for HTML Touch events to lib.d.ts
#1224 EventListener interface does not accept objects with a handleEvent method
(not sure) #1075 IDBKeyRange definition is degraded
#674 MouseEvent constructor is missing parameters
#314 SourceBuffer.appendBuffer() is missing overload for ArrayBufferView param in lib.d.ts

@mhegazy
Copy link
Contributor

mhegazy commented Apr 7, 2015

That might need a new PR, or a force push on this branch, but it would be nice if we can get in the change to dom.generated.d.ts to sort it using the old script. Then add a commit with your change. this way we can look at the diff of the two commits and see the actual change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants